search

tweag / webauthn

A library for parsing and validating webauthn/fido2 credentials
Apache License 2.0
34 stars 11 forks source link

Json improvements #144

Closed infinisil closed 8 months ago

lykahb commented 2 years ago

@Infinisil Would you like some help to finish this PR? I'd be interested to use webauthn without the orphan instances exported.

infinisil commented 2 years ago

I have now created an issue in the webauthn spec highlighting underspecified signature formats: https://github.com/w3c/webauthn/issues/1721

lykahb commented 9 months ago

The spec issue is resolved now. I can't tell if the answer makes the signature format more clear, though.

Is there anything I can help with to get this merged, @infinisil? It seems the only part of this PR that is unclear and related to the spec is the changes for the COSE signatures. So, we could take it out of the PR and instead of replacing ByteString with Cose.CoseSignature, replace it with Base16ByteString. Getting rid of the orphan instances is an easier improvement than COSE and we could do this sooner.

infinisil commented 9 months ago

I don't expect to have any time to work on this myself, but I'd be happy to review an updated PR! Splitting this up a bit sounds good too.