search

tweag / webauthn

A library for parsing and validating webauthn/fido2 credentials
Apache License 2.0
34 stars 11 forks source link

Add support for the credProps extension #157

Closed mortenson closed 1 year ago

mortenson commented 1 year ago

Per https://github.com/tweag/webauthn/issues/35#issuecomment-1371564697 , this PR adds support for the credProps extension (ref https://www.w3.org/TR/webauthn-2/#sctn-authenticator-credential-properties-extension).

I added a test attestation to validate the parsing, and also used the test server locally to manually test that the feature (at least appears to be) working:

Screenshot 2023-01-19 at 1 46 41 PM

This is my first time contributing to this repository (or any OSS Haskell repo), so please let me know if you need any changes.

Thank you!

lykahb commented 1 year ago

Looks good to me. @infinisil would you like to review?

ErinvanderVeen commented 1 year ago

Hej! Thank you for your contribution. I'm going to leave a review before the end of tomorrow. @infinisil will probably also take a look sometime soon.

It looks good as far as I've looked at it, we really appreciate you taking the time to improve the library.

Kindly, Erin

ErinvanderVeen commented 1 year ago

I think this would resolve #35 Doesn't solve that issue to the extend required.

infinisil commented 1 year ago

webauthn-0.5.0.0 released :)