JSON improvements, revisited

tweag / webauthn

A library for parsing and validating webauthn/fido2 credentials

Apache License 2.0

34 stars 11 forks source link

JSON improvements, revisited #178

Closed lykahb closed 8 months ago

lykahb commented 8 months ago

This is based on https://github.com/tweag/webauthn/pull/144

Compared to that PR, this branch:

is based on master
replaces JPEGBytes with PNGBytes
fixes build errors

It seems that @infinisil's concerns about the COSE signature and the spec are related to the choice of algorihtm, and are orthogonal to the refactoring that introduces newtypes CoseMessage and CoseSignature.

lykahb commented 8 months ago

Thanks for the review @infinisil. I could see how Base16ByteString could be misinterpreted that way. Instead of PrintableByteString I chose a name PrettyHexByteString instead - it both shows that its main purpose is pretty-printing and that it displays it as hex. Let me know what you think.

The documentation for the COSE newtypes points to the rfc8152. I am not deeply familiar how COSE should work, so can you take a look at that?

The haddock has full coverage with no warnings.