search

tweag / webauthn

A library for parsing and validating webauthn/fido2 credentials
Apache License 2.0
34 stars 11 forks source link

Fix building web server for Node 18 #179

Closed lykahb closed 8 months ago

lykahb commented 8 months ago

Upgrading parcel fixes https://github.com/parcel-bundler/parcel/issues/8005

infinisil commented 8 months ago

Huh, what impurity caused it to suddenly fail?

lykahb commented 8 months ago

The nix did not capture the js dependencies.

infinisil commented 8 months ago

Aren't those supposed to be pinned by the yarn.lock file?

lykahb commented 8 months ago

Hmm, that's a good point. The yarn lock file is not in nix, but it still freezes the dependencies. It could've also been that the https://github.com/tweag/webauthn/commit/f8644ce3fe83993b42f86f8c51acb83aa0e93f08 upgraded NodeJS to 18. So, the frozen dependencies couldn't work with the later Node.