In #43, #49 and #51 better tests were added, but we can still expand them:
Test all the attestation and assertion errors. This should be doable by having Arbitrary instances for all parameters that are necessary to change to get all these errors, running the simulation with them, and making sure the errors we get are what we expect given the generated values. E.g. we generate two origins, and if they aren't the same, we want to get an AttestationOriginMismatch in the Validation
Have tests for the attestation statement formats and ideally their errors as well
In #43, #49 and #51 better tests were added, but we can still expand them:
Arbitrary
instances for all parameters that are necessary to change to get all these errors, running the simulation with them, and making sure the errors we get are what we expect given the generated values. E.g. we generate two origins, and if they aren't the same, we want to get anAttestationOriginMismatch
in theValidation