tweaked-programs / cccbridge

CC:C Bridge is a mc mod that adds compatibility between the ComputerCraft and Create mod!
https://cccbridge.tweaked-programs.cc/
Apache License 2.0
29 stars 15 forks source link

Advancement loading error on startup #91

Open tmvkrpxl0 opened 6 months ago

tmvkrpxl0 commented 6 months ago

Description Insert a clear and concise description of what the bug is. This error is printed on startup:

[06:19:57] [main/ERROR] [minecraft/ServerAdvancementManager]: Parsing error loading custom advancement cccbridge:place_animatronic: Failed to parse 'location' field
[06:19:57] [main/ERROR] [minecraft/ServerAdvancementManager]: Parsing error loading custom advancement cccbridge:place_redrouter: Failed to parse 'location' field

and I believe advancement is not working correctly due to this.

To Reproduce Steps to reproduce the behavior:

  1. Install cccbridge
  2. Start world. Preferably on dedicated server as the output is more cleaner.
  3. Observe that error

Expected behavior Insert a clear and concise description of what you expected to happen. I expected advancement to word without issue.

Software (please complete the following information):

tmvkrpxl0 commented 6 months ago

According to official source, "conditions" must contain "location" field. But advancements of cc bridges does not. Below is part of place_redrouter.json

    "criteria": {
        "placed_redrouter": {
            "trigger": "minecraft:placed_block",
            "conditions": {
                "block": "cccbridge:redrouter_block"
            }
        }
    }

It just contains "block"

SammyForReal commented 6 months ago

Thank you for this issue! Yeah that indeed seems to be a mistake from my side. I will try to fix this.

tmvkrpxl0 commented 3 months ago

when?

tmvkrpxl0 commented 1 month ago

when?