Open baltpeter opened 7 months ago
One potential reason I can think of for not replacing the path with a URL: One might want to get the research documentation as of the version of TrackHAR they are using and not the (potentially) updated one on our site.
However, then I realized that we don't actually ship the documentation as part of the bundle, which seems like an oversight to me. (Though it does raise additional questions, like should we maybe export it as a JS object or something since you can't exactly easily access Markdown files bundled in a JS package…).
We decided to:
research-docs
folder.
For reasonings that point to our own research documentation, we currently return the (relative) path to the Markdown file in
process()
. Here's how that looks incli
as an example:I'm unsure whether that's the correct way to go. We could also replace the path with the URL to the hosted documentation on trackers.tweasel.org.
Even if we decide against doing that, I think we should at least:
Update the docstring to explain what the Markdown paths means and how to get to the Markdown file as well as how to construct the URL to the hosted documentation. (The docstring really needs to be updated either way—first-party documentation is not "a more in-depth research report.)
https://github.com/tweaselORG/TrackHAR/blob/b2191417c38634dcc0124e07b14f282bdc80f404/src/index.ts#L171-L181
cli
.