Hello,
I modified the 'getFileAsURL' function for the GCS and Azure Adapters to add the possibility of getting both a public URL and a signed URL for files in private buckets. We use this funcionality for files in Azure and GCS, but the GCS Adapter only returned public URLs, making it impossible to download files from private buckets even though we were authenticated. With the changed I am proposing we can still get the public URL as before and the signed URL if we need it. I also updated the use of the options parameter so it is actually used in those two adapters.
abudaan
commented
3 months ago
Hello, I modified the 'getFileAsURL' function for the GCS and Azure Adapters to add the possibility of getting both a public URL and a signed URL for files in private buckets. We use this funcionality for files in Azure and GCS, but the GCS Adapter only returned public URLs, making it impossible to download files from private buckets even though we were authenticated. With the changed I am proposing we can still get the public URL as before and the signed URL if we need it. I also updated the use of the options parameter so it is actually used in those two adapters.