I appreciate the enthusiasm and effort, but I will not accept this PR. The commit messages are not indicative of the changes made, and I can't see any real benefit for the change. I also prefer to keep comprehensions as simple as possible . Additionally, the boilerplate styles in the first out assignment is missing from the return line.
To be constructive: I ignore E501 linter warnings, but always look for a break opportunity to keep the lines reasonable. There was such an opportunity before the if in the generator comprehension that would keep it under 79 chars and improved legibility.
I appreciate the enthusiasm and effort, but I will not accept this PR. The commit messages are not indicative of the changes made, and I can't see any real benefit for the change. I also prefer to keep comprehensions as simple as possible . Additionally, the boilerplate styles in the first
outassignment is missing from the return line.To be constructive: I ignore E501 linter warnings, but always look for a break opportunity to keep the lines reasonable. There was such an opportunity before the
ifin the generator comprehension that would keep it under 79 chars and improved legibility.