search

tweenjs / es6-tween

ES6 version of tween.js
MIT License
186 stars 34 forks source link

Additionaly check in TWEEN.Tween.to function #72

Closed seIncorp closed 5 years ago

seIncorp commented 5 years ago

I added additionally check in TWEEN.Tween.to, if the this.object is equal to this._valuesEnd. If not all excess parameters are removed.

dalisoft commented 5 years ago

Thanks. But this feature causes some bugs/collision in tweening. I don’t think this needed

seIncorp commented 5 years ago

Thanks. But this feature causes some bugs/collision in tweening. I don’t think this needed

There was some issues with white spaces.

dalisoft commented 5 years ago

I see, CI passed, but i have real experience with these bugs. The bug will appear when two tweens with same node, like independent tweening for same node with different property

seIncorp commented 5 years ago

I see, CI passed, but i have real experience with these bugs. The bug will appear when two tweens with same node, like independent tweening

Now I see what you meant. If you want you can remove it or try to fix this issue.

dalisoft commented 5 years ago

These issue may appear after merging this PR, now this issue i fixed with Store cache