search

tweenjs / tween.js

JavaScript/TypeScript animation engine
https://tweenjs.github.io/tween.js/
Other
9.85k stars 1.41k forks source link

Improved yoyo documentation #644

Closed iangilman closed 1 year ago

iangilman commented 1 year ago

It wasn't clear from the documentation that I had to pass anything into the yoyo function. I had to go look at the yoyo example page to figure that out. Hopefully this change will make it clear to the next person.

trusktr commented 1 year ago

Thanks! Good catch @iangilman!

trusktr commented 1 year ago

Hmm, oh! Looks like the docs are already update-to-date here:

https://github.com/tweenjs/tween.js/blob/main/docs/user_guide.md#yoyo

We need to sync github pages, rather than update github pages directly.

Tracking issue: https://github.com/tweenjs/tween.js/issues/645

iangilman commented 1 year ago

Funny! Glad I could help highlight the sync issue, though that was unintended 😄

Thank you for cherry picking my commit so I could get credit. ❤️