search

tweetstream / em-twitter

Twitter Streaming API client for EventMachine
http://rubygems.org/gems/em-twitter
MIT License
42 stars 16 forks source link

Rename #respond_to argument variable. #17

Closed larrylv closed 10 years ago

larrylv commented 10 years ago

The second parameter stands for "if private and protected methods are included", not just private methods, so include_private should be renamed to include_all.

larrylv commented 10 years ago

The builds are failing.

Apparently respond_to? behaves differently on 1.9 and 2.0.

class A

  protected

    def foo
    end
end

A.new.respond_to? :foo returns true on 1.9, but false on 2.0

So should I just remove the specs added, or close this PR?

stve commented 10 years ago

Hi @larrylv thanks for the pull request. I can definitely understand how the variable name could be confusing. I'm not so worried about the specs as you are essentially testing ruby at that point. Feel free to remove the test from the PR and I'll merge. Thanks.

larrylv commented 10 years ago

@spagalloco I've updated the PR.

stve commented 10 years ago

thanks for the submission @larrylv