search

tweh / menukeys

A LaTeX package to typeset menu sequences, key strokes, paths etc.
46 stars 4 forks source link

Don't rely on catoptions #60

Closed Skillmon closed 3 years ago

Skillmon commented 3 years ago

This PR removes the catoptions dependency and uses expl3 instead.

Since catoptions is no longer compatible with LaTeX, this PR removes menukeys' dependency on it. The used expl3 functions are let to names private to menukeys resembling the names of the replaced catoptions macros. I tried documenting the places where the provided macros differ in behaviour to the ones provided by catoptions.

As a small test I build the documentation, which worked without error.

This fixes #59

tweh commented 3 years ago

Thank you very much for investing the time and work! Is your pull request considered “final”, I could check it and publish it as an update soon.

Skillmon commented 3 years ago

@tweh yes, it is. Thank you very much! You might want to polish the documentation changes though :) I don't request the acknowledgement on the title page, it's more like a "blame that guy" statement from my point of view. If you think it isn't appropriate feel free to remove it.

Skillmon commented 3 years ago

Oh, if you happen to accept this PR, we should register the used expl3 prefix for you.

tweh commented 3 years ago

I just send the spade to CTAN. Thanks again for your work, Joseph!

I don't request the acknowledgement on the title page, it's more like a "blame that guy" statement from my point of view. If you think it isn't appropriate feel free to remove it.

Of course this should be mentioned on the title page, however I rephrased it a bit …

Skillmon commented 3 years ago

@tweh If you want, I can become a part time maintainer for this code as well, since you said you don't have much time currently.

tweh commented 3 years ago

@Skillmon This sounds great, can I share this repo so that you can access directly without the need of your fork?

Skillmon commented 3 years ago

Yes, you can. If you don't know, you have to go to the settings page of this repository, there you can select "Manage access" from the menu on the left, and invite me as a collaborator.

tweh commented 3 years ago

Thanks. I sent you an invitation and prepared the manual and readme to mention both of our names as author. Feel to add your email address as well. For the next CTAN update this could also be changed. I have a txt file contacting the CTAN information I could send you by email since it is not part of the repository. Maybe you could send me an e mail so we can discuss the rest “in private”? (Maybe GitHub has a feature for this as well …)

Cheers, Tobi