search

twekkel / htpdate

HTTP Time protocol
https://www.vervest.org/htp
Other
50 stars 13 forks source link

Use pkg-config to determine openssl LDFLAGS #17

Closed ffontaine closed 2 years ago

ffontaine commented 2 years ago

Depending on its build configuration, openssl might not be compiled with dynamic zlib support, and programs that link against openssl need to link against zlib as well, as illustrated in this build failure: http://autobuild.buildroot.net/results/ae9/ae946ca72238840b3eaa5fe823e8d620618f7462/

Signed-off-by: Titouan Christophe titouan.christophe@railnova.eu [Retrieved (and slightly updated) from: https://github.com/angeloc/htpdate/commit/72fcf9f82770e927e058a2eaa327d0eecb1e3c8d] Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

twekkel commented 2 years ago

Have seen that commit, but didn't include it deliberately. It introduces an extra dependency on pkg-config being installed.

It looks like ucLibc specific specific issue... can it not be solved in a more elegant way?

twekkel commented 2 years ago

does this make sense to you?

https://github.com/twekkel/htpdate/tree/use-pkg-config

ffontaine commented 2 years ago

Static build is not related to uclibc-ng, however, I understand that you don't want to add a pkg-config dependency. In this case, I would suggest to move -lssl in a dedicated variable such as SSL_LIBS. Then, I would override SSL_LIBS with the result of pkg-config in buildroot httpdate.mk

twekkel commented 2 years ago

like this? https://github.com/twekkel/htpdate/commit/4ba90fedd553c3b06c925fb6ff5245a5dcabace9

ffontaine commented 2 years ago

Yes, perfect. I'll pull this commit in buildroot, thanks.

tpetazzoni commented 2 years ago

A bit sad that pkg-config was not used. It could have been used optionally, i.e only if available.