search

twelve-of-code-official / website

The source code for the Twelve of Code website
https://mesure.x10.mx/twelve-of-code
GNU General Public License v3.0
0 stars 0 forks source link

Made twelve of code Netlify action only apply to pull requests with the twelve of code label #101

Closed BeepBot99 closed 8 months ago

BeepBot99 commented 8 months ago

@Mesure73L Do these steps:

  1. Delete the required action in the branch protection rule
  2. Accept and merge this pull request
  3. Merge BeepBot99-patch-1 into develop
  4. Add the branch protection rule back
BeepBot99 commented 8 months ago

You might also need to update the site id if it's changed at all.

Mesure73L commented 8 months ago

Do I just check this checkbox or do something else? image

Mesure73L commented 8 months ago

By the way, are we still gonna set up the previews for the other site pages?

BeepBot99 commented 8 months ago

Do I just check this checkbox or do something else?

You click the x next to the Netlify action and click save at the bottom of the page. Then, you do steps 2 and 3 in my previous response, and then add netlify/m73l-twelve-of-code-dev/deploy-preview back.

BeepBot99 commented 8 months ago

By the way, are we still gonna set up the previews for the other site pages?

Yes, eventually.

BeepBot99 commented 8 months ago

Actually, I would just remove the required status check once and for all. The purpose of it was to ensure that the deployed preview was reviewed before merging, but I don't think we really need that anymore.