twelve-of-code-official / website

The source code for the Twelve of Code website
https://mesure.x10.mx/twelve-of-code
GNU General Public License v3.0
0 stars 0 forks source link

Create data import and export #140

Closed BeepBot99 closed 6 months ago

BeepBot99 commented 6 months ago

Resolves #15. (One of the oldest issues yay.)

netlify[bot] commented 6 months ago

Deploy Preview for m73l-twelve-of-code-dev ready!

Name Link
Latest commit 2909a985b6436214f3bb1e9072b76b87fa89c83c
Latest deploy log https://app.netlify.com/sites/m73l-twelve-of-code-dev/deploys/65d6be1bd5eb5500085b1a96
Deploy Preview https://deploy-preview-140--m73l-twelve-of-code-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

BeepBot99 commented 6 months ago

@Mesure73L Do the hover effects on the buttons look good to you?

BeepBot99 commented 6 months ago

LGTM, if you can make it go center out on hover and opposite for off hover that would be nice, but you can merge

What do you mean?

BeepBot99 commented 6 months ago

@Mesure73L Can I please have your opinion on the new hover effect?

BeepBot99 commented 6 months ago

I believe I have finished, but I have not yet tested it with every possibility possible. Can you please do that?

BeepBot99 commented 6 months ago

@Mesure73L Can you please review this today?

BeepBot99 commented 6 months ago

What if I changed twelve-of-code-export.txt to twelve-of-code-export-data.txt or twelve-of-code-data.txt? Would that be better?

Mesure73L commented 6 months ago

Reviewing this RN

BeepBot99 commented 6 months ago
  • Make the X button on the import data modal act as a cancel button to fix this problem.

I tried that, I don't exactly know how to do it, but I can try again.

  • Add a #settings hash to make it not close the settings tab on data reload.

Okay.

3. Check the data with information.json to prevent this problem.

Oh, I thought I had already fixed that. I will do it again.

Yes, use twelve-of-code-data.

Isn't that the first thing I had suggested?????

Mesure73L commented 6 months ago

What is the Changed something commit?

BeepBot99 commented 6 months ago

IDK look at it.

BeepBot99 commented 6 months ago

Oh right yeah it's important.

BeepBot99 commented 6 months ago

Actually please don't merge this yet I want to change something.

Mesure73L commented 6 months ago

IDK look at it.

That's why you should be more clear with commit names

BeepBot99 commented 6 months ago

Okay actually it's fine. It could be slightly cleaner by changing that last commit, but it doesn't actually significantly affect anything.

BeepBot99 commented 6 months ago

Yes, I did that on purpose. Why not allow it if it can just be removed?

Mesure73L commented 6 months ago

Where did 2023 go?

BeepBot99 commented 6 months ago

It wasn't in the data that was entered. But, when any request for it is made, it will be added.

Mesure73L commented 6 months ago

ohhh thats why i said that but makes sense

Mesure73L commented 6 months ago

@BeepBot99 merge when 🟥y