twelve-of-code-official / website

The source code for the Twelve of Code website
https://mesure.x10.mx/twelve-of-code
GNU General Public License v3.0
0 stars 0 forks source link

Contributing policy #145

Closed Mesure73L closed 6 months ago

Mesure73L commented 6 months ago

@BeepBot99 what are your thoughts on the policy?

netlify[bot] commented 6 months ago

Deploy Preview for m73l-twelve-of-code-dev canceled.

Name Link
Latest commit 057e74eafc488ffa8d7ac87e238d899a93325a7d
Latest deploy log https://app.netlify.com/sites/m73l-twelve-of-code-dev/deploys/65d95de03f139c0008fce32e
BeepBot99 commented 6 months ago

Where can the new policy be viewed? It cannot be seen here. image

Mesure73L commented 6 months ago

Where can the new policy be viewed? It cannot be seen here.

Look it up, from what I read it does not appear in the overview but can be seen in issues and pull requests, and it can also be linked to like every other markdown file.

BeepBot99 commented 6 months ago

I do not use the default settings in prettier. I set the max line width to 140 characters instead of 80 and I also changed some other stuff. However, as long as you are using some version of prettier, it will be fine. That is because prettier does not offer many options. No matter what your settings are, it will always look roughly the same. So, I think it is fine how it is, but I am just letting you know about that.

Mesure73L commented 6 months ago

I do not use the default settings in prettier. I set the max line width to 140 characters instead of 80 and I also changed some other stuff. However, as long as you are using some version of prettier, it will be fine. That is because prettier does not offer many options. No matter what your settings are, it will always look roughly the same. So, I think it is fine how it is, but I am just letting you know about that.

"recommended"

Mesure73L commented 6 months ago

I never said anything about what you use

BeepBot99 commented 6 months ago

Okay tell me when this is ready for reveiw.

Mesure73L commented 6 months ago

Actually, can you send me your full config?

BeepBot99 commented 6 months ago

Just for Prettier or for all of VS Code?

Mesure73L commented 6 months ago

Just for Prettier

BeepBot99 commented 6 months ago

Sure, here it is:

{
    "editor.formatOnPaste": true,
    "editor.linkedEditing": true,
    "prettier.arrowParens": "avoid",
    "prettier.bracketSpacing": false,
    "prettier.bracketSameLine": true,
    "prettier.printWidth": 100,
    "prettier.tabWidth": 4,
    "prettier.trailingComma": "none",
    "prettier.quoteProps": "consistent",
    "editor.defaultFormatter": "esbenp.prettier-vscode"
}
Mesure73L commented 6 months ago

Sure, here it is:

{
    "editor.formatOnPaste": true,
    "editor.linkedEditing": true,
    "prettier.arrowParens": "avoid",
    "prettier.bracketSpacing": false,
    "prettier.bracketSameLine": true,
    "prettier.printWidth": 100,
    "prettier.tabWidth": 4,
    "prettier.trailingComma": "none",
    "prettier.quoteProps": "consistent",
    "editor.defaultFormatter": "esbenp.prettier-vscode"
}

How do I input that?

BeepBot99 commented 6 months ago

Why'd you ask for it if you don't know how to input it?

Mesure73L commented 6 months ago

I thought you would just tell me, but please answer it

BeepBot99 commented 6 months ago
  1. Do ctrl + , to get to settings. You can also click on settings in the bottom left corner and then click settings.
  2. In the top right, click on the paper with an arrow. The tooltip says, "Open Settings (JSON)."
  3. For each settings that I sent, change it to my value if it is already there, or add it to the end if it is not already there.
BeepBot99 commented 6 months ago

Add https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github please.

BeepBot99 commented 6 months ago

image What is this?

Mesure73L commented 6 months ago

Add https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github please.

Okay, I will.

image What is this?

That is me merging the commit I made on GitHub to my GHCS clone. If you hover over it, it didn't interfere with any other branches at all.

BeepBot99 commented 6 months ago

Oh right imagine being in school today. /t

Mesure73L commented 6 months ago

Oh right imagine being in school today. /t

"DON'T SKIP SCHOOL EVER" "Imagine skipping school today" (both quotes from you)

Mesure73L commented 6 months ago

@BeepBot99 please review this

Mesure73L commented 6 months ago

then dont tell me to put the link on the list

BeepBot99 commented 6 months ago

Okay fine I'll just do it myself then.

BeepBot99 commented 6 months ago

Okay, I won't actually, because then I won't be able to review it, but can you please just change the name?