search

twelve-of-code-official / website

The source code for the Twelve of Code website
https://mesure.x10.mx/twelve-of-code
GNU General Public License v3.0
0 stars 0 forks source link

Added usage of CookieManager.__proto__.updateChallengeStatus() to example challenge #149

Closed BeepBot99 closed 6 months ago

BeepBot99 commented 6 months ago

Resolves #146.

netlify[bot] commented 6 months ago

Deploy Preview for m73l-twelve-of-code-dev ready!

Name Link
Latest commit 7da7bed1e26a7ef7b7cfd5721cebbec9e1612cb7
Latest deploy log https://app.netlify.com/sites/m73l-twelve-of-code-dev/deploys/65d96b510ec5080008e2f8fe
Deploy Preview https://deploy-preview-149--m73l-twelve-of-code-dev.netlify.app/not-an-api/challenges/2023/dec/1
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

BeepBot99 commented 6 months ago

It's December 1st btw.

Mesure73L commented 6 months ago

bro just simplify the title name instead of ...ing it

BeepBot99 commented 6 months ago

I didn't do the ..., it is automatic.

Mesure73L commented 6 months ago

well it still looks ugly

BeepBot99 commented 6 months ago

IDFC what you think.

BeepBot99 commented 6 months ago

By the way, check the name now.

Mesure73L commented 6 months ago

IDFC what you think.

BeepBot99 commented 6 months ago

Just review this please you literally asked for it.

BeepBot99 commented 6 months ago

Okay, but cman is all you need to use. Swal2 is just optional for feedback, but is not required. Alternatively, if you want, I could make it so cman.updateChallengeStatus() always fires a Swal2 alert when called.

Mesure73L commented 6 months ago

I would like something to say "You completed the challenge!" or "That is not the correct answer." or something using SWAL2

BeepBot99 commented 6 months ago

Just in the individual challenge or in cman.updateChallengeStatus()?

Mesure73L commented 6 months ago

Maybe add another argument to cman.updateChallengeStatus() for the message, its a success thing if the challenge is completed and error if it wasnt, and make it look like the data input

BeepBot99 commented 6 months ago

What do you mean "make it look like the data input?" Also, I think I'll just put it in the program, because cman.updateChallengeStatus() is only called when the status changes, but when you get it wrong twice in a row, it will not be called.

Mesure73L commented 6 months ago

What do you mean "make it look like the data input?"

Make the SWAL2 style the same as the data input

Also, I think I'll just put it in the program, because cman.updateChallengeStatus() is only called when the status changes, but when you get it wrong twice in a row, it will not be called.

What do you mean by the program? I want it to always run if the user gets it wrong.

BeepBot99 commented 6 months ago

How could it not be the same as the data input? And by the program, I mean the program that this pull request is about you very amazing person who I am very appreciative of.

Mesure73L commented 6 months ago

How could it not be the same as the data input?

swal has different styles and options idiot

Mesure73L commented 6 months ago

And by the program, I mean the program that this pull request is about you very amazing person who I am very appreciative of.

Okay, thanks for the kind clarification!

BeepBot99 commented 6 months ago

I'm the one that set up swal, not you. To use a different style, you would have to add another CDN reference to the <head>.

BeepBot99 commented 6 months ago

And by the program, I mean the program that this pull request is about you very amazing person who I am very appreciative of.

Okay, thanks for the kind clarification!

How is that kind?????

Mesure73L commented 6 months ago

I'm the one that set up swal, not you. To use a different style, you would have to add another CDN reference to the <head>.

Okay, I did not know that, but yes you set it up that's why I don't know how things work. Also I also mean like the success or error thing in the data input, like in the corner and stuff not a modal in the center of the screen

Mesure73L commented 6 months ago

And by the program, I mean the program that this pull request is about you very amazing person who I am very appreciative of.

Okay, thanks for the kind clarification!

How is that kind?????

How isn't it????????????????????????????????????

Mesure73L commented 6 months ago

Please do not become Aurify. image image also why does it need to reload?

BeepBot99 commented 6 months ago

Because when cman.updateChallengeStatus() is called, it automatically reloads.

Mesure73L commented 6 months ago

Then don't use updateChallengeStatus() unless it was successful

BeepBot99 commented 6 months ago

Yes, but if it was unsucessful, I set it to in progress. Did you even read the code?

Mesure73L commented 6 months ago

If the answer was correct the challenge should never be marked as not completed, ever

BeepBot99 commented 6 months ago

Yes, when is it?????

Mesure73L commented 6 months ago

SO WHY ARE YOU CALLING UPDATECHALLENGESTATUS

BeepBot99 commented 6 months ago

To mark it as completed.

Mesure73L commented 6 months ago

SO WHY DOES IT NEED TO RELOAD IF IT WAS INCORRECT

BeepBot99 commented 6 months ago

Because it's marking it as in progress.

🤯

BeepBot99 commented 6 months ago

What is so confusing?

Mesure73L commented 6 months ago

Because it's marking it as in progress.

🤯

don't mark it as in progress. thats for if its like a game or something where its not i/o. i/o should always be true or false

BeepBot99 commented 6 months ago

No, it's in progress because it means you started attempting it but didn't finish yet. I am not changing it.

Mesure73L commented 6 months ago

Then I am changing it.

BeepBot99 commented 6 months ago

Well then I'm not accepting this pull request.

BeepBot99 commented 6 months ago

Okay, fine, I don't care, you're the one who asked for this.

Mesure73L commented 6 months ago

well I got the information I need from it, so im just gonna use it from the branch and not actually put it on 12oc