twelve-of-code-official / website

The source code for the Twelve of Code website
https://mesure.x10.mx/twelve-of-code
GNU General Public License v3.0
0 stars 0 forks source link

12oC challenge selector keeps challenge active after making the month unset #32

Closed Mesure73L closed 9 months ago

Mesure73L commented 9 months ago

What happened?

I clicked 2023 for the year, December for the month, and then Challenge 2 (although I don't think any of those selections matter, that's just what I chose).

Nothing was wrong until I clicked December again to disable it, and then I clicked it a third time. Challenge 2 was still appearing active even though it shouldn't be. (The challenge itself didn't appear, but the button was still appearing as active. Also, the JavaScript knew it shouldn't be active, just a visual glitch that should be fixed.)

What did you expect to happen?

I expected the challenge to not be appearing as active, because it wasn't active and shouldn't be active.

What page was this on?

twelve of code

What browser(s) were you experiencing this on?

Google Chrome (desktop)

Enter logs

No response

Other notes

I'll give screenshots of what I did.

image image image image image image

Mesure73L commented 9 months ago

I want to fix this to help myself understand the logic used in the new twelve-of-code/script.js, even if it would be faster for @BeepBot99 to fix this.

BeepBot99 commented 9 months ago

Just letting you know, I am currently working on something in script.js. It might be easier if you do it later to avoid merge conflicts. I am currently only working in the settings section of the code, so if you do decide to do it now, please do not change anything there.

Mesure73L commented 9 months ago

Just letting you know, I am currently working on something in script.js. It might be easier if you do it later to avoid merge conflicts. I am currently only working in the settings section of the code, so if you do decide to do it now, please do not change anything there.

I will wait until you are done, let me know when I can create a new branch to fix this bug.

BeepBot99 commented 9 months ago

You can work on this now.

Mesure73L commented 9 months ago

Bug fixed and tested, probably also fixed the other bugs that you were talking about yesterday