TWNTY-3219 - `twenty-favicon` not loading favicons for some sites

[gitstart-app[bot]]

Description

We encountered a problem displaying icons for websites with the .ico extension, resulting in a broken image being shown to users. This issue arose because ico-to-png was not parsing these files into a format compatible with Sharp. In response, we now utilize Sharp for the initial conversion to PNG.

Refs

https://github.com/twentyhq/twenty/issues/3219

Demo

Before

After

Fixes https://github.com/twentyhq/twenty/issues/3219

[gitstart-twenty]

Hey @FelixMalfait, Please check this out

[charlesBochet]

@gitstart-twenty I remember that some format were not supported by sharp. If this works, this is great! But I'll double check it today that all previously supported format are still supported with this change

[gitstart-twenty]

@gitstart-twenty I remember that some format were not supported by sharp. If this works, this is great! But I'll double check it today that all previously supported format are still supported with this change

Alright @charlesBochet

This handles both image/vnd.microsoft.icon and image/x-icon MIME-types though.