search

twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.
https://twenty.com
GNU Affero General Public License v3.0
16.07k stars 1.82k forks source link

Migrate field type probability to rating #3531

Closed FelixMalfait closed 2 months ago

FelixMalfait commented 8 months ago

I saw in the code we have a field type "probability": https://github.com/twentyhq/twenty/blob/aa8d689e3e4a2a923dddd6c0b33ad458a127fa66/packages/twenty-server/src/metadata/field-metadata/field-metadata.entity.ts#L30

I don't think we should have both Probability and Rating. We should only keep one field type (probability)

Eventually this field type could have additional options to customize the display and values in the future

charlesBochet commented 6 months ago

Let's remove it!

FelixMalfait commented 4 months ago

OK I think this should be very quick (just a few lines of code to delete?), it doesn't seem to be used.

But Opportunity probability used to be of type rating I think? And now it's just a basic string? we should fix this and bring it back