twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.
https://twenty.com
GNU Affero General Public License v3.0
15.53k stars 1.62k forks source link

Standardize Relation Icons Across Application #5660

Closed Bonapara closed 2 weeks ago

Bonapara commented 2 months ago

Current Behavior

We have an inconsistency in how we display relation icons across the app.

Fields list on an object detail page:

CleanShot 2024-05-29 at 17 57 14

New relation field icon:

CleanShot 2024-05-29 at 17 56 58

Customization of a new relation field:

image

Desired Behavior

We want to display this icon for one-to-many relations:

CleanShot 2024-05-29 at 17 57 37

And this icon for many-to-many relations.

CleanShot 2024-05-29 at 17 59 07

By default, we want to display the one-to-many icon everywhere.

ijayhub commented 2 months ago

Please is this opened? If it is can I work on this.

Bonapara commented 2 months ago

Sure @ijayhub, thanks for contributing!

ijayhub commented 2 months ago

I am currently having an issue forking the repo GitHubDesktop_cJQiTnnbli please could anyone assist me? Thanks

Bonapara commented 2 months ago

@ijayhub maybe ask on our Discord: https://discord.com/invite/cx5n4Jzs57

ijayhub commented 2 months ago

okay thanks

Bonapara commented 1 month ago

@ijayhub did it work?

NitinPSingh commented 2 weeks ago

hi @Bonapara , "has many" and "belongs to one" both are 1:N relationship ? download (1)

and can you tell where N:N relationship is used in app? download

Bonapara commented 2 weeks ago

@NitinPSingh, you're right. All relations are indeed 1:N for now. "Belongs to" is N:1, but there's no icon for this, so let's use 1:N as well!

NitinPSingh commented 2 weeks ago

@Bonapara can you review the changes made in pr #6504