search

twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.
https://twenty.com
GNU Affero General Public License v3.0
15.72k stars 1.71k forks source link

Redis cache store cannot be password protected #6423

Closed falko100 closed 4 days ago

falko100 commented 1 month ago

Currently only REDIS_HOST and REDIS_PORT are available within the .env settings. If we want to use a managed redis cluster for our self-hosted twenty, we need to enter a password.

Bonapara commented 1 month ago

@charlesBochet WDYT?

charlesBochet commented 3 weeks ago

@falko100 @Bonapara Happy to review a PR to add it to environment variables and leverage it in the code :) Looks a legit feature

borel commented 2 weeks ago

Hey @charlesBochet , @Bonapara hope everything fine .

It looks quite straight forward to do by adding REDIS_USERNAME and and REDIS_PASSWORD as var env and manage them in [ cache-storage.module-factory, message-queue.module-factory, .env ]

I can work on it if needed

charlesBochet commented 2 weeks ago

@borel sure, go ahead! I'm happy to review and merge the PR as part of 0.24

BalanaguYashwanth commented 2 weeks ago

Hello @borel,

Are you working on it ?

borel commented 2 weeks ago

hey @BalanaguYashwanth , hope you well . Yes i am .

BalanaguYashwanth commented 1 week ago

@borel Didn;t understand

Bonapara commented 1 week ago

Are you still on it @borel? Thanks for contributing

borel commented 1 week ago

Hey @Bonapara , i started to contribute on it but i will probably don't have time in the coming days :(

https://github.com/twentyhq/twenty/pull/6745

DurgaManikantaSai commented 1 week ago

is anyone working on this? I want to work on it. May I ?

Bonapara commented 1 week ago

I think you can work on it, @DurgaManikantaSai, either starting from scratch or using @borel's draft!

Thank you for contributing :)

DurgaManikantaSai commented 6 days ago

@Bonapara I am working on It. Thanks

DurgaManikantaSai commented 4 days ago

@Bonapara I think some one known as @Weiko fixed this from @borel's draft. Should I have to leave this and search for some other suitable issues ?

Bonapara commented 4 days ago

@Weiko should we close it?

Weiko commented 4 days ago

Yes, this has been solved.