twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.
https://twenty.com
GNU Affero General Public License v3.0
15.8k stars 1.73k forks source link

When scrolling inside the table with scrollbar, cursor also selects rows #6773

Open BOHEUS opened 2 weeks ago

BOHEUS commented 2 weeks ago

Scenario:

  1. Log in
  2. Go to object page (e.g. Companies)
  3. Create at least 100 objects so table won't be able to load them all thanks to pagination and scroll will appear
  4. Scroll a bit for the scrollbar to appear and try to use scrollbar to move up/down the table

Actual: When moving scrollbar, cursor also is able to select multiple rows Screencast from 2024-08-28 18-35-28.webm

Expected: When moving scrollbar, cursor is only moving scrollbar

Faisal-imtiyaz123 commented 2 weeks ago

@BOHEUS I would like to work here.

Bonapara commented 2 weeks ago

Sure @Faisal-imtiyaz123, thanks for contributing!

janvi01 commented 2 weeks ago

I would like to work on this @Bonapara

charlesBochet commented 2 weeks ago

I can reproduce should be easy to fix, we should de-activate the drag start on the scrollbar. We already have this kind of mechanism to not start the drag on column header click

Bonapara commented 1 week ago

@Faisal-imtiyaz123 are you still on it? Otherwise will assign you @janvi01. Thank you both for contributing!

Faisal-imtiyaz123 commented 1 week ago

@Bonapara I am on it.

Faisal-imtiyaz123 commented 1 week ago

@BOHEUS I made 120 objects . Couldn't reproduce it. Are you sure it wasn't an accidental selection which caused rows to be selected.

BOHEUS commented 1 week ago

@Faisal-imtiyaz123 I'm still reproducing it, both locally on newest changes and on demo, I'm sure it wasn't an accidental selection as I clicked on scroll (sadly, it's not visible on video as software didn't capture a cursor for some weird reason) and @charlesBochet confirmed it can be reproduced, I also checked and it's not limited to specific browser like it's in some cases

Faisal-imtiyaz123 commented 1 week ago

@BOHEUS Oh! I think it is reproducible when number of objects is large. Let me create a large number of objects and then see.