twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.
https://twenty.com
GNU Affero General Public License v3.0
15.79k stars 1.73k forks source link

Exclude Soft-Delete Page from Last Seen View #6786

Closed Bonapara closed 1 week ago

Bonapara commented 2 weeks ago

Current behavior

By default, we now display the last seen view when navigating back to an object.

This included the soft-delete view

https://github.com/user-attachments/assets/85170e9e-8296-454f-9d7b-a5d6a433d021

Desired Behavior

The soft-delete page should not be considered as the last seen view, Instead, we should ideally redirect to the view displayed before the soft-delete page. In the worst case, redirect to the "All records" view.

Bonapara commented 2 weeks ago

@lucasbordeau FYI

Nabhag8848 commented 2 weeks ago

will take this up, after completion of my draft prs, do assign.🔥

Bonapara commented 2 weeks ago

Sure @Nabhag8848, thanks for contributing!

Nabhag8848 commented 2 weeks ago

@Bonapara I need more clearity on what you meant from soft-delete page should not be considered .

https://github.com/user-attachments/assets/efb7c6f1-8586-49d8-be94-1acfb08c51e3

https://github.com/user-attachments/assets/6eea7608-6cec-497d-8c1f-3f9f8d7f8b61

https://github.com/user-attachments/assets/ecffc66f-4f32-4f14-a5b7-7e2f6757e4a6

charlesBochet commented 1 week ago

@Bonapara I cannot reproduce either, the current behavior described by @Nabhag8848 looks good to me. Could you give more details?

Bonapara commented 1 week ago

Thanks, @Nabhag8848, for your valuable input.

We should remove the temporary filter autosave when someone exits a view. For example, if I apply a filter on the People > Suppliers view and then switch to the People > Customers view, the filter should be removed when I return to the People > Suppliers view.

However, we want to ensure the filter remains active while still within the context of the view. For instance, if I access a detail page from a temporarily filtered view, I don't want to lose my filters when I return to the list view from the detail page.

Nabhag8848 commented 1 week ago

@Bonapara I think this can be closed as resolved by changes within #6897 for filters but solves this too.