search

twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.
https://twenty.com
Other
20.18k stars 2.24k forks source link

API Docs - Remove 'disabled' from link input for the local host option. #6900

Closed danxcraig closed 3 weeks ago

danxcraig commented 2 months ago

I can submit a PR if approved for this one.

Details

https://twenty.com/developers/rest-api/core#/

There are plenty of times a person might not select the default port of 3000 when running on localhost (for example, if they already have a service running on that port).

However, when localhost is selected from the dropdown, the input field for the url is disabled, so the developer has no other choice either to abandon, or to figure out they can use 'Other', which isn't necessarily intuitive.

Suggestion is that input is enabled so that the user can update the port/address if required.

Bonapara commented 2 months ago

Then maybe we should only keep Other? And change Other to Localhost/Other

danxcraig commented 2 months ago

Then maybe we should only keep Other? And change Other to Localhost/Other

I like it, but maybe just Custom? Makes it more obvious that this is the box you can put your own stuff in, but you won't be able to in the other two.

Bonapara commented 2 months ago

@FelixMalfait if you have an opinion

FelixMalfait commented 2 months ago

What you can do is change the input field to be editable and automatically match the select value to the string in the input field. So if a person goes and change the text then it automatically switches to "Other", unless for example it's changed to https://api-demo.twenty.com, then it becomes "Demo API" Thanks a lot

FelixMalfait commented 2 months ago

@danxcraig do you want to raise a PR or should I close this? happy to merge the PR if you do! Thanks a lot

danxcraig commented 2 months ago

Thanks @FelixMalfait it's been a hectic week but yep I should finally have some time to take a crack at this tomorrow in the way you suggested.

FelixMalfait commented 2 months ago

Oh great thanks @danxcraig!

FelixMalfait commented 3 weeks ago

@danxcraig I'll close this since it's been open for long but a PR would always be welcome if you ever have time. No problem if not! Thanks