twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.
https://twenty.com
GNU Affero General Public License v3.0
15.82k stars 1.74k forks source link

Remove dependency to chakra-ui #6976

Closed FelixMalfait closed 4 days ago

FelixMalfait commented 1 week ago

We copy/pasted a spreadsheet-importer components which had a few chakra-ui components.

We should get rid of them and migrate to internal equivalents.

https://github.com/twentyhq/twenty/blob/main/packages/twenty-front/src/modules/spreadsheet-import/steps/components/MatchColumnsStep/components/UnmatchColumn.tsx#L11

I think it's just used in the context of matching values of select fields

ehconitin commented 1 week ago

Working on this @FelixMalfait

Question - we dont have internal equivalents to those components right?

FelixMalfait commented 1 week ago

Thanks a lot @ehconitin!

I think we do have equivalent already. @Bonapara can probably help here!

Bonapara commented 1 week ago

We might not need an accordion for this one. Instead we could use our Banner component with a chevron down icon instead of the CTA and hardcode the opening/closing behavior.

Close

CleanShot 2024-09-11 at 16 32 57

Open

CleanShot 2024-09-11 at 16 33 20

ehconitin commented 6 days ago

Got it!

ehconitin commented 6 days ago

PR 7004

ehconitin commented 4 days ago

Merged ✅ Could you please close this issue

charlesBochet commented 4 days ago

Yes, ty!