twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.
https://twenty.com
GNU Affero General Public License v3.0
15.9k stars 1.76k forks source link

Date picker clips through navigation bar in mobile #7014

Open harshit078 opened 1 week ago

harshit078 commented 1 week ago

Bug Description

Current Behaviour

Screenshot 2024-09-13 at 12 59 50 AM Screenshot 2024-09-13 at 1 00 38 AM

Expected behavior

It should automatically reposition it's orientation to top just like Phone number field.

Screenshot 2024-09-13 at 1 01 55 AM
sephialaureenciaa commented 1 week ago

Hi, Can I contribute to this?

HKS07 commented 4 days ago

Hey @Bonapara and @harshit078 can I work on this.

I have already done some changes to the UI as shown in video for both full screen and mobile screen.

Full Screen

https://github.com/user-attachments/assets/996729d9-3231-426c-a0ea-5b1ea26b726a

Mobile Screen

https://github.com/user-attachments/assets/5dcd775b-2656-409f-8dd9-2bcc6ea87c1e

Please tell me if any changes are needed.

Bonapara commented 1 day ago

Thanks @HKS07. Is the calendar still cropped on mobile? At what point does it start getting cropped?

HKS07 commented 1 day ago

It is starting cropped around 420 px [width].

image

Shouldn't there be media query used to make it compatible for small size devices? If yes, then what width should I target?

Bonapara commented 1 day ago

I think it should work up to 360px @HKS07. We should aim for the same "desired behavior" as in this issue: https://github.com/twentyhq/twenty/issues/7216

I also noticed an overflow issue with the navbar in your screenshot, @harshit078:

CleanShot 2024-09-23 at 18 45 46

harshit078 commented 18 hours ago

@Bonapara, you are correct ! It overflows through the navigation bar if the user scrolled down and it will not reposition itself.

https://github.com/user-attachments/assets/96073cc8-0e00-4e83-9eb2-b8eb37a6b6b3