twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.
https://twenty.com
Other
20.08k stars 2.23k forks source link

Add all necessary currencies #7038

Closed BOHEUS closed 1 month ago

BOHEUS commented 1 month ago

Based on #7033 and other issues/PRs adding more currencies, instead of adding them one by one, it's better to add them all at once. This way, there won't be complaints about missing someone's currency or missing ability to add them by themselves in UI.

### Tasks
- [ ] Research what currencies are available in the world
- [ ] Add currencies with correct code and symbols
- [ ] Add search for currencies when creating a new model like it's for Opportunities records ![image](https://github.com/user-attachments/assets/a34b95ed-0505-4650-a705-b65fcd69100c)
harshit078 commented 1 month ago

Currently we are using around 20 currency and based on currency picker library and npm modules, we need to add around 10-15 more currency to support most used currency around the world which would bring the total count to be around 35

BOHEUS commented 1 month ago

Even if we all those 10-15 currencies, there are still more missing currencies according to ISO 4217 (https://en.wikipedia.org/wiki/ISO_4217#Active_codes_(list_one)), author of linked issue wanted to add a currency which isn't one of the most popular, so either:

BOHEUS commented 1 month ago

@Bonapara what do you think, should all currencies be hardcoded or Twenty should allow adding them? If former, then I can implement this

BOHEUS commented 1 month ago

From fast check, it seems like there are missing icons for some currencies in icons-react package like Malagasy ariary or Ghanaian cedi, what should be done then? https://en.wikipedia.org/wiki/Currency_symbol

Bonapara commented 1 month ago

I think we can automate this. We use Tabler-icons for icons. Do you think we can fetch the available ones from Tabler-icons and display Coins when the currency is not available?

CleanShot 2024-10-03 at 10 36 42

BOHEUS commented 1 month ago

Sure, that won't be a problem