twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.
https://twenty.com
Other
20.39k stars 2.26k forks source link

The settings flash during loading #7102

Closed Bonapara closed 1 month ago

Bonapara commented 2 months ago

Current behavior

The Settings page flashes on load.

https://github.com/user-attachments/assets/6cdbe08c-79ff-44f5-b211-c5297298154c

Desired Behavior

The White background layout should always be loaded and not flash on every page change. We should put a small Skeleton to indicate the page loading. The breadcrumb should not be part of the loading and already displayed (if possible).

image

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=40069-430620&node-type=frame&t=vjg6Ofev4bkaijG1-11

Techical guidelines

@lucasbordeau

Muralidhar22 commented 2 months ago

Hi @Bonapara Can I work on this?

Bonapara commented 2 months ago

Sure, thanks for contributing @Muralidhar22!

Muralidhar22 commented 1 month ago
Screenshot 2024-09-24 at 12 04 36 AM

Hi @Bonapara / @lucasbordeau would this work, I added suspense fallback element.

Bonapara commented 1 month ago

I believe @charlesBochet mentioned it was an issue with caching the layout. This needs to be confirmed by him or @lucasbordeau.