search

twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.
https://twenty.com
Other
17.8k stars 2.1k forks source link

Don't automatically redirect to the "New Function" page when pressing the "Enter" key on the "/settings/functions" page #7235

Closed Devessier closed 1 month ago

Devessier commented 1 month ago

Bug Description

Wherever the focus is on the "/settings/functions" page, pressing the "Enter" key will always navigate to the "New Function" page. This breaks accessibility.

Example:

https://github.com/user-attachments/assets/05d3a0f0-1345-45d3-bacf-5bd02b611282

Expected behavior

The page should not listen to the Enter key and let the browser behave naturally.

Technical inputs

Remove that code: https://github.com/twentyhq/twenty/blob/fcaa9d9aed625bb8923fe0b2cffc20b989850d7c/packages/twenty-front/src/modules/settings/serverless-functions/components/SettingsServerlessFunctionsTable.tsx#L34-L40

ehconitin commented 1 month ago

Hello @Devessier! This hotscope was introduced in #6656 , so are we supposed to revert it completely or find a better way to implement hotscope in serverless functions?

Devessier commented 1 month ago

Thanks @harshit078 and @ehconitin for your contribution. This issue has been solved.