twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.
https://twenty.com
Other
20.35k stars 2.26k forks source link

[ESLint plugin] Add a rule to enforce folder architecture on frontend #7329

Closed ijreilly closed 4 weeks ago

ijreilly commented 1 month ago

Scope & Context

Follow: https://docs.twenty.com/contributor/frontend/folder-architecture and enforce it with linter We have diverge a bit from the docs, let's what we have in the project right now. If there are some inconsistencies let's discuss them here.

Bonus :

Technical inputs

See if there is an existing ESLint rule to enforce it If not create a custom rule in tools/eslint-rules

gitstart-connector[bot] commented 1 month ago

Issue synced into GitStart. Please review, edit and hand it off to GitStart by following this link.

ijreilly commented 1 month ago

Input from @charlesBochet

We should

  1. create the rule as a warning
  2. check folder by folder to avoid big conflicts on the project
  3. change the rule as error
ijreilly commented 1 month ago

@gitstart-twenty For this issue please open PRs folder by folder if relevant and not a big PR with a lot at once, otherwise we will have too much conflicts

ijreilly commented 1 month ago

(Recreating this issue to help sync with @gitstart-twenty ticket studio)