twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.
https://twenty.com
Other
23.54k stars 2.43k forks source link

[Storybook Testing] Fix NavigationDrawer story #7492

Open charlesBochet opened 1 month ago

charlesBochet commented 1 month ago

Context

This issue is part of a Storybook effort on the project. You will find more context and guidance in the main issue: https://github.com/twentyhq/twenty/issues/7491

What

Fix the following existing story: /story/ui-navigation-navigationdrawer-navigationdrawer--default

image
charlesBochet commented 1 month ago

/oss.gg 150

oss-gg[bot] commented 1 month ago

Thanks for opening an issue! It's live on oss.gg!

naaa760 commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

You already have an open issue assigned to you here. Once that's closed or unassigned, only then we recommend you to take up more.

Harsh-Sanklecha commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

Assigned to @Harsh-Sanklecha! Please open a draft PR linking this issue within 48h ⚠ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹ī¸ Excited to have you ship this 🚀

KartikDevarde2601 commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] commented 1 month ago

@Harsh-Sanklecha, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Kushalshakya commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

This issue is already assigned to another person. Please find more issues here.

Anky9972 commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

This issue is already assigned to another person. Please find more issues here.

SahillRazaa commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

This issue is already assigned to another person. Please find more issues here.

AndrewHamal commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

Assigned to @AndrewHamal! Please open a draft PR linking this issue within 48h ⚠ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹ī¸ Excited to have you ship this 🚀

oss-gg[bot] commented 1 month ago

@Harsh-Sanklecha, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

charlesBochet commented 1 month ago

/unassign

oss-gg[bot] commented 1 month ago

Issue unassigned.

Kushalshakya commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

Assigned to @Kushalshakya! Please open a draft PR linking this issue within 48h ⚠ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹ī¸ Excited to have you ship this 🚀

oss-gg[bot] commented 1 month ago

@AndrewHamal, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

AndrewHamal commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] commented 1 month ago

@AndrewHamal, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

oss-gg[bot] commented 1 month ago

@Kushalshakya, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

charlesBochet commented 1 month ago

/unassign

oss-gg[bot] commented 1 month ago

Issue unassigned.

sateshcharan commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

Assigned to @sateshcharan! Please open a draft PR linking this issue within 48h ⚠ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹ī¸ Excited to have you ship this 🚀

uluckydev commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

This issue is already assigned to another person. Please find more issues here.

sateshcharan commented 1 month ago

@uluckydev you can attempt this now if you are still interested !

AndrewHamal commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

You already have an open issue assigned to you here. Once that's closed or unassigned, only then we recommend you to take up more.

uluckydev commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

Assigned to @uluckydev! Please open a draft PR linking this issue within 48h ⚠ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹ī¸ Excited to have you ship this 🚀

oss-gg[bot] commented 1 month ago

@sateshcharan, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

uluckydev commented 1 month ago

I tried running the storybook with npx nx run twenty-front:storybook:serve:dev --configuration=modules command. The frontend getting stopped and the frontend is not working. Any idea how can i fix that for dev environment?

sateshcharan commented 1 month ago

@uluckydev only storybook will start with limited config will start for npx nx run twenty-front:storybook:serve:dev --configuration=modules you can access it at port 6006

uluckydev commented 1 month ago

@sateshcharan I tried it. It is running on the first time but when I am going to NavigationDrawer story the frontend stopped responding.

uluckydev commented 1 month ago

https://github.com/user-attachments/assets/49accf5e-5388-4e3a-8e59-779330c4fe1d hey @sateshcharan Please refer to this video, I even tried the --verbose. Do you think it can happen because of the codespace?

sateshcharan commented 1 month ago

https://github.com/user-attachments/assets/49accf5e-5388-4e3a-8e59-779330c4fe1d hey @sateshcharan Please refer to this video, I even tried the --verbose. Do you think it can happen because of the codespace?

it probably is, try local dev it worked for me

Pk9697 commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

Assigned to @Pk9697! Please open a draft PR linking this issue within 48h ⚠ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹ī¸ Excited to have you ship this 🚀

oss-gg[bot] commented 1 month ago

@Pk9697, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.

oss-gg[bot] commented 1 month ago

@Pk9697 has not opened a PR for this issue within 48 hours. They have been unassigned from the issue; anyone can now take it up.

Pk9697 commented 1 month ago

/assign

oss-gg[bot] commented 1 month ago

Assigned to @Pk9697! Please open a draft PR linking this issue within 48h ⚠ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹ī¸ Excited to have you ship this 🚀