search

twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.
https://twenty.com
Other
23.12k stars 2.41k forks source link

favorite folders followup #8570

Closed ehconitin closed 2 days ago

ehconitin commented 3 days ago

Something changed, which affected the Favorite folder picker checkbox styles -- fixed it! Cleaned up code in CurrentWorkspaceMemberFavoritesFolders - removed redundant filtering since favorites are already filtered in usePrefetchedFavoritesData. Regarding issue #8569 - I am not sure what to do in this case. Since Folders data is gated by a feature flag, we can't use it in CurrentWorkspaceMemberFavoritesFolders to ensure the favorite section renders with empty folders. Currently, the section only appears when at least one favorite exists - may be leave this section open at all times or fix this bug after removal of the feature flag?

github-actions[bot] commented 2 days ago

Thanks @ehconitin for your contribution! This marks your 58th PR on the repo. You're top 1% of all our contributors 🎉 See contributor page - Share on LinkedIn - Share on Twitter

Contributions