twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.
https://twenty.com
Other
23.51k stars 2.43k forks source link

cannot hide or move No Value for custom stage field on kanban view #8591

Open code1704 opened 6 days ago

code1704 commented 6 days ago
  1. add a custom stage field to some object
  2. add a kanban view

Bug: cannot hide No Value; cannot move No Value to the top

Image

khuddite commented 6 days ago

I will take a look

sriharika13 commented 5 days ago

I understand the issue, Pl assign it to me, I can solve it

khuddite commented 5 days ago

@Bonapara It seems hide/dnd(drag-and-drop) has been intentionally disabled for no value groups in this PR - https://github.com/twentyhq/twenty/commit/e8d96cfd10fc4d6fd1bb9bf14dd6761e2f372120

Now, do we wanna change that behavior and not differentiate them?

You can check out these 2 specific lines in the PR -

const noValueViewGroups =
    viewGroups.filter(
      (viewGroup) => viewGroup.type === RecordGroupDefinitionType.NoValue,
    ) ?? [];

  const viewGroupsWithoutNoValueGroups = viewGroups.filter(
    (viewGroup) => viewGroup.type !== RecordGroupDefinitionType.NoValue,
  );

(https://github.com/khuddite/twenty/blob/24c0b0f8733565912efda91077597773cb1909a1/packages/twenty-front/src/modules/views/components/ViewGroupsVisibilityDropdownSection.tsx#L53)

Bonapara commented 5 days ago

Hi @khuddite I think we might change that behavior so the "no value" acts like other groups if it doesn't break anything.

khuddite commented 5 days ago

@Bonapara If that's the path we wanna follow, I will make the necessary changes in a way nothing breaks.

Bonapara commented 5 days ago

Notion allows it, so I don't see why we wouldn't!