Fix wrong getAll keyValue method - Githubissues

twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.

https://twenty.com

Other

23.51k stars 2.43k forks source link

Fix wrong getAll keyValue method #8603

Closed martmull closed 5 days ago

martmull commented 5 days ago

Fixes https://github.com/twentyhq/twenty/issues/8520#issuecomment-2485913500

Fix the getAll key-value pairs method, as it returns incorrect results. The keyVar values were being affected by keyValues from other workspaces.
Fix missing Sync Email step for existing users joining existing workspace

Before, this method returned keyValues that verifies:

workspaceId = user.defaultWorkspaceId
userId = user.id

This method now returns:

userId = null && workspaceId = user.defaultWorkspaceId
userId = user.id && workspaceId = null
userId = user.id && workspaceId = user.defaultWorkspaceId

Result

https://github.com/user-attachments/assets/b7563db6-a6a8-4e09-a0c6-c372d7e2b712