twentyhq / twenty

Building a modern alternative to Salesforce, powered by the community.
https://twenty.com
Other
23.04k stars 2.41k forks source link

Treat no value view group as normal & enable hide/dnd for no value #8613

Open khuddite opened 1 day ago

khuddite commented 1 day ago

Fixes #8591

  1. Summary We disabled hide/dnd(drag-and-drop) options for No value view group intentionally in the first implementation. We want to change it to behave like normal view groups, so enable hide/dnd for No value view group as well.

  2. Solution I have removed the code that filters the No value group out of view groups, so No value is stored in the same array as other view groups. I have removed the No value flag check for Hide button on the hamburger menu of the Kanban header. I had to update the code in packages/twenty-front/src/modules/views/utils/mapViewGroupsToRecordGroupDefinitions.ts because it was ignoring the visibility flag of the No value view group and set it always to true. Also, it was always putting the No value group last ignoring the previous position.

    I am not 100% confident in the changes I made in packages/twenty-front/src/modules/views/utils/mapViewGroupsToRecordGroupDefinitions.ts. I'd like to have a review from someone more familiar with that part.

  3. Recording https://github.com/user-attachments/assets/e135e22e-6e3a-4f94-a898-aafc03bba060