twgardner2 / navy_psr

1 stars 0 forks source link

Psr parser #19

Closed ChaseWPDEV closed 2 years ago

ChaseWPDEV commented 2 years ago

This is a beast of a pull request. It started with a simple idea: enable PDF parsing -- and escalated quickly. Core ideas:

twgardner2 commented 2 years ago

This looks amazing.

I fear I accidentally started a formatting war: I was just trying to fix one curly brace that was indented one tab too far, then my local prettier settings changed the whole file, so I figured we should add a .prettierrc and agree on formatting rules, then I ended up reformatting other files I looked at (I think because of reflexive ctrl-s). Anyway, there is a .prettierrc now, feel free to config it the way you like :)

I also added data/ back into the .gitignore. I have that directory locally with my PSR and a guy whose PSR I hand-jammed into CSV and showed him the resulting graph. I figure I should keep that off the internet.

I'm getting an error, probably something I did wrong.

I installed:

image

I built:

image

I launched a local webserver:

image

I go to the page and get an error that I'm not smart enough to have figured out yet:

image

ChaseWPDEV commented 2 years ago

@twgardner2

  1. Re formatting war -- good call on the prettierrc file. I generally suck at conforming to established formatting standards. This collab will be a good chance for me to force myself to do better.

  2. Re Bogus build -- this one's on me. I had been hacking around in node_modules to figure out what I needed to do to build a custom webpack loader to make the pdf parsing work -- those hacks had consequences that I didn't clean up properly. The latest commit (893eb29) should fix it.

twgardner2 commented 2 years ago

Sweet, the build is working now. Unfortunately I have some contractors doing work in my backyard and they cut my internet ☹️. I couldn’t find my PSR in pdf format to play around with the parser, but will as soon as my internet is back up.

On Sun, Jan 9, 2022 at 19:23 ChaseWPDEV @.***> wrote:

@twgardner2 https://github.com/twgardner2

1.

Re formatting war -- good call on the prettierrc file. I generally suck at conforming to established formatting standards. This collab will be a good chance for me to force myself to do better. 2.

Re Bogus build -- this one's on me. I had been hacking around in node_modules to figure out what I needed to do to build a custom webpack loader to make the pdf parsing work -- those hacks had consequences that I didn't clean up properly. The latest commit (893eb29 https://github.com/twgardner2/navy_psr/commit/893eb29d1f43868d90d3095fbe3f0e1f056392f9) should fix it.

— Reply to this email directly, view it on GitHub https://github.com/twgardner2/navy_psr/pull/19#issuecomment-1008455821, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGJVYJYGFZUH7IE2UGD57NTUVIRIZANCNFSM5LRJRVNA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- Sent from my iPhone. Please excuse any typos or brevity.