search

twhiteaker / CFGeom

CF Convention for Representing Simple Geometry Types
MIT License
9 stars 4 forks source link

Fix _get_splits_ #10

Closed twhiteaker closed 8 years ago

twhiteaker commented 8 years ago

Modify _getsplits so that it splits input array without dropping array values other than the split value. See https://github.com/bekozi/netCDF-CF-simple-geometry/issues/6#issuecomment-223412791.

bekozi commented 8 years ago

Nice catch. Did you want to add a test? I can add one otherwise. The tests only covered the case where an interior split had a single element! https://github.com/bekozi/netCDF-CF-simple-geometry/blob/master/src/python/ncsg/test/test_ncsg/test_cf.py#L38

twhiteaker commented 8 years ago

I'll add a test.