search

twhiteaker / CFGeom

CF Convention for Representing Simple Geometry Types
MIT License
9 stars 4 forks source link

Rename geom_type to geometry_type #63

Closed twhiteaker closed 7 years ago

twhiteaker commented 7 years ago

On 2017-02-07, Jonathan Gregory sent to the CF-metadata list in response to renaming the geom_type attribute:

If you keep "geometry" I would like to appeal not to abbreviate it to "geom" since we usually do not abbreviate in CF. (Abbreviations can make things harder to remember and may cause inconsistencies since there may be more than one possible abbreviation.)

I'm ok with the rename. Note that there was also talk of renaming to topology_type. I think of geometry as an individual shape, and I think of topology as the relationship between shapes, e.g., I share the same edge as this other watershed boundary. So I prefer geometry over topology for our case.

dblodgett-usgs commented 7 years ago

I knew there was a reason I moved all that stuff to variables. https://github.com/dblodgett-usgs/NCDFSG/blob/master/R/AAA.R#L20

Yeah. I'll make that change.

twhiteaker commented 7 years ago

OK, I'll hit the readme then. Let's close when updated in R and readme.

dblodgett-usgs commented 7 years ago

https://github.com/dblodgett-usgs/NCDFSG/commit/a43c112eb1bbacba721e4670494ff368be1e7a9a

Also updated the wiki.

twhiteaker commented 7 years ago

Fixed in readme.md in 00df34385bd760671c749914be0c24a2367bece0, and in R code and wiki.