twifty / atom-phpunit-integrator

PHPUnit for the Atom editor
MIT License
1 stars 1 forks source link

Don't move cursor when invoking "Run test method" #35

Closed Gert-dev closed 6 years ago

Gert-dev commented 6 years ago

Another tale from the battlefield :-).

"Run test method" is a really useful command to quickly run only the test the cursor is in. Unfortunately, for some reason this command decides to move the cursor to the start of the method signature after having done that, which takes away focus from what you were doing.

To make matters worse, you can't run "Run test method" again when the method is on the signature, so a constant "Move cursor", "Run test method", "Move cursor" is required.

twifty commented 6 years ago

Ahh. One of the package settings allows you to enable/disable opening of the test file when running a test case from a normal source file.

I see two problems here. 1) The first/final line of the method should still enable that command. Looks like the scope detection needs a little tweak. 2) I should detect if the editor is already for the test class and abort opening the file (which is where the cursor is positioned).

twifty commented 6 years ago

Fixed in 0.0.30

Funny thing is, I had a //TODO written just above problem 1. A difference between buffer positions and file positions.