search

twig / dcxdll

Dialog Control eXtensions for mIRC
BSD 3-Clause "New" or "Revised" License
23 stars 2 forks source link

Build fails because of missing svnBuild.h #2

Closed hapm closed 10 years ago

hapm commented 10 years ago

As of the svn version of dcx there was a svnBuild.h generated by SubWCRev.exe (part of TortoiseSVN) that defined the SVN_BUILD macro, what is used to define the DLL_BUILD.

This requires that TortoiseSVN is installed and the base repo is an svn repo. This should be replaced by a more elegant way, that abstracts the underlying scm system and generates proper DLL_BUILD values, even if there is no scm at all.

For a fast workaround, the svnBuild.h and all dependence should be removed from the git repo, as they're wrong here.

OokEek commented 10 years ago

a replacement system needed, ideas?

jbaez001 commented 10 years ago

Well...A couple of things come to mind. git has no revision numbers so, how about actually tagging actual versions and building off of that? For example:

PS X:\dev\src\dcxdll> git tag -m 'DCX 4.2.6' 4.2.6 PS X:\dev\src\dcxdll> git describe 4.2.6 PS X:\dev\src\dcxdll> git commit --allow-empty -m 'Welll...' [master bb8b181] Welll... PS X:\dev\src\dcxdll> git describe 4.2.6-1-gbb8b181 PS X:\dev\src\dcxdll> git commit --allow-empty -m 'Another empty commit' [master 92ce35e] Another empty commit PS X:\dev\src\dcxdll> git describe 4.2.6-2-g92ce35e

hapm commented 10 years ago

I like the tagging idea.