search

twigphp / Twig

Twig, the flexible, fast, and secure template language for PHP
https://twig.symfony.com/
BSD 3-Clause "New" or "Revised" License
8.18k stars 1.25k forks source link

Improve exception expectations reliability #4277

Closed alexandre-daubois closed 2 months ago

alexandre-daubois commented 2 months ago

This PR moves exception expectations the closest possible to the line intended to throw. It improves reliability of tests ensuring that the right code is throwing the expected exception and not something else (resulting in false-positive). This has been done many times across Symfony code base.

fabpot commented 2 months ago

Thank you @alexandre-daubois.