search

twigphp / Twig

Twig, the flexible, fast, and secure template language for PHP
https://twig.symfony.com/
BSD 3-Clause "New" or "Revised" License
8.18k stars 1.25k forks source link

Improve formatDate methods phpdoc #4328

Closed VincentLanglet closed 1 month ago

VincentLanglet commented 1 month ago

convertDate

So the phpdoc should not be \DateTimeInterface|string|null but \DateTimeInterface|string|int|null

And all the date methods using convertDate should also accepts int and null.

This is important since some tools are developing static analysis on twig.

fabpot commented 1 month ago

Thank you @VincentLanglet.