search

twigphp / Twig

Twig, the flexible, fast, and secure template language for PHP
https://twig.symfony.com/
BSD 3-Clause "New" or "Revised" License
8.14k stars 1.25k forks source link

Simplify compiled `for` loop code #4355

Closed ruudk closed 3 days ago

ruudk commented 3 days ago

Do not pass closure as reference It's not needed.

Do not use same var names in loop function These variables are passed in when the loop function is invoked when yielding. Giving them the same internal var names complicates things for no good reason.

fabpot commented 3 days ago

Thank you @ruudk.