twilight-rs / twilight

Powerful, flexible, and scalable ecosystem of Rust libraries for the Discord API.
https://discord.gg/twilight-rs
ISC License
670 stars 131 forks source link

fix(validate): improve validation of command option descriptions #2269

Closed randomairborne closed 1 year ago

randomairborne commented 1 year ago

The validation for several options was incorrect. This PR fixes that issue.

randomairborne commented 1 year ago

I believe the current clippy failure should be ignored, because in theory the min length could change and doing this is more correct IMO. Let me know what I should do here.

itohatweb commented 1 year ago

Yea, ig in this case an ignore should be ok. Don't forget to update the doc comment for the test too /// o .-.