twilight-rs / twilight

Powerful, flexible, and scalable ecosystem of Rust libraries for the Discord API.
https://discord.gg/twilight-rs
ISC License
670 stars 131 forks source link

feat(gateway)!: impl Stream for Shard #2309

Closed vilgotf closed 9 months ago

vilgotf commented 9 months ago

Public API change log

Gelbpunkt commented 9 months ago

From what I could tell this code is indeed now cancellation safe, which is an awesome improvement. Thanks a lot for the PR!

Gelbpunkt commented 9 months ago

Commit message and title should be updated to include a ! to indicate the breaking change. To make writing a changelog easier, I would also like the PR description to mention deserialize_wanted with stream adapters as a replacement for next_event.

Erk- commented 9 months ago

The Shard::stream module was removed.

This should probably have been the stream module.