twilio-labs / NgrokExtensions

Visual Studio integration with ngrok
MIT License
48 stars 26 forks source link

Ngrok for VS2019 #25

Closed TomBruns closed 4 years ago

TomBruns commented 5 years ago

Add support for VS2019

dprothero commented 5 years ago

@craigomatic @TomBruns Can you try out this release? https://github.com/dprothero/NgrokExtensions/releases/tag/v0.9.12

luebster commented 5 years ago

@craigomatic @TomBruns Can you try out this release? https://github.com/dprothero/NgrokExtensions/releases/tag/v0.9.12

Confirmed works in Visual Studio Enterprise 2019 version 16.0.2

tomasmcguinness commented 5 years ago

I'm using this release in VS2019, but my setup seems to be confusing it.

When running my project, I use http and https

image

When I launch ngrok from the Tools menu, it results in this:

image

The forwarding is using the SSL port and a non-existent port. Any ideas how I can correct this on my side?

luebster commented 5 years ago

I believe you have to uncheck Enable SSL in the project properties. I realize this will be a problem testing https.

image

derekantrican commented 4 years ago

Similar to what @luebster posted, I found that there is a problem with ngrok not forwarding if you have the "Configure for HTTPS" box checked when creating a new ASP.NET Web Application (it's checked by default) Note that this only applies to VS 2019

image

Not sure where this could be changed, but I contacted ngrok support and here's what they had to say:

ngrok supports this, yes, but i'm not sure how the visual studio plugin would handle it. (the visual studio plugin is maintained by a third party). this is how it's done via the command line tool: https://ngrok.com/docs#http-local-https

dprothero commented 4 years ago

Oh wow, nice sleuthing @derekantrican -- I will see if the ngrok API lets me do this (the plugin is using the API)

dprothero commented 4 years ago

VS 2019 support is in place, so I'm closing this issue.

The https issue is being tracked on issue #29