search

twilio-labs / actions-sms

Send an SMS through GitHub Actions
MIT License
148 stars 40 forks source link

node_modules checked in? #22

Closed jeffreyhawkins closed 9 months ago

jeffreyhawkins commented 4 years ago

Why is node_modules checked into the repo?

welcome[bot] commented 4 years ago

Thank you so much for opening your first issue for this project! We'll try to get back to it as quickly as possible. While you are waiting...here's a random picture of a corgi (powered by dog.ceo)

picture of dog

bnb commented 9 months ago

@jeffreyhawkins because of how GitHub Actions works, you're required to check in node_modules unless you're doing a bundling step.

jeffreyhawkins commented 9 months ago

@bnb it's probably wise to use ncc to bundle as outlined in the GifHub Action documentation. Including the node_modules is a red flag for our organization for the simple fact we've seen binaries in the node_modules from various dependencies.