Added maxHeight for call history Box

twilio-labs / dev-phone

A developer tool for testing SMS and Voice applications

MIT License

75 stars 20 forks source link

Added maxHeight for call history Box #166

Closed bkannanv closed 1 year ago

bkannanv commented 1 year ago

Fixes #145

Added maxHeight to Box component.

size80 is the same height being used in the Parent component Softphone

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

[ ] I acknowledge that all my contributions will be made under the project's license.

ayyrickay commented 1 year ago

Hey, thanks for opening this PR! I'm about to check this out, but at a glance it looks like it should work. :) Could you document the changes with a changeset?

bkannanv commented 1 year ago

I have added the Changeset, but by default it took the change as patch bump, but according to the notes this should be beta bump.

As of 30 Sep 2022, the Dev Phone is still in a prerelease, and so all version bumps are beta version bumps (no major, minor, or patch). This should create some changes in the Changelogs and package.json that need to be committed and pushed to GitHub. Be sure to commit both the version branch and the tag.

Can you help me update the Changeset as beta bump? I am not quite sure how to do it.

Thanks.